Bypassing the stream_is_selected If Operation#27
Open
alexguanga wants to merge 9 commits intosinger-io:masterfrom
Open
Bypassing the stream_is_selected If Operation#27alexguanga wants to merge 9 commits intosinger-io:masterfrom
stream_is_selected If Operation#27alexguanga wants to merge 9 commits intosinger-io:masterfrom
Conversation
Contributor
|
Hi @alexguanga, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. |
Contributor
|
You did it @alexguanga! Thank you for signing the Singer Contribution License Agreement. |
Author
|
@cmerrick - Following up on the PR, is there any additional specification/requirements I should follow? Thanks! |
|
Hello, Any news on this? |
Author
Nope, have not heard any updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Introduced functionality to bypass the
stream_is_selectedby passing an argument in theconfig.jsonwhen running the--propertiesflag.Desired Exact code change
Why Are We Proposing the Change?
--discovernor the--propertiesflag. Instead, we are piping the data from the Tap to the Target with the--configflag directly.--config, we need to execute the functionality of the--discoverand--propertiesin one sync and not two.About the Desired Code Change
truefor theskip_stream_is_selectedin the config.sample.json, we are able to bypass the--propertiesand--discoverflag.--propertiesand--discoverflag. The difference is that we performing this with only the--configflag. To be able to this, we can either:--propertiesstream_is_selectedflag, it will bypass thestream_is_selectedif operation.Workflow
- Please note that the workflow is an addition to what's provided by singer's io tap-s3-csv, it does not affect any current workflows.
skip_stream_is_selectedtotruein theconfig.jsontap-s3-csv --config config.jsonManual QA steps
Risks
Rollback steps