SAC-28847: Add parent-tap-stream-id key in metadata#84
Open
MuralidharT03 wants to merge 6 commits intomasterfrom
Open
SAC-28847: Add parent-tap-stream-id key in metadata#84MuralidharT03 wants to merge 6 commits intomasterfrom
MuralidharT03 wants to merge 6 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for tracking parent-child relationships between streams by including a parent-tap-stream-id key in the metadata. This enables better understanding of stream hierarchies during data discovery operations.
- Added logic to detect parent stream relationships and store parent stream ID in metadata
- Enhanced metadata with parent-tap-stream-id field when a parent stream exists
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RushiT0122
requested changes
Oct 15, 2025
Contributor
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
Update discovery integration tests.
Author
Added tests in the latest commit |
RushiT0122
approved these changes
Oct 17, 2025
Contributor
RushiT0122
left a comment
RushiT0122
left a comment
There was a problem hiding this comment.
Approving this PR but update tap version to minor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
SAC-28847
Manual QA steps
Run Discovery
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code