Skip to content

Exit loop if start_after is None and add per_page to query string #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahuynh3 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Exit loop if start_after is None and add per_page to query string #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf3f9de
Exit loop if start_after is None and add per_page to query string
ahuynh3 Sep 25, 2020
91ba1cb
Update description in CHANGELOG
ahuynh3 Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,29 @@
# Changelog

## 0.1.1

- Break out of sync loop for cursor based pagination if `starting_after` is None
- Pass in `per_page` query param to `next_url`

## 0.1.0
* Add `sla_applied` and `statistics` objects.

- Add `sla_applied` and `statistics` objects.

## 0.0.4
* Adjust `client.py` to use API `v.2.0`.
* Remove `users` and `leads` streams.
* Add `contacts` stream.
* Add support for `cursor` style paging.

- Adjust `client.py` to use API `v.2.0`.
- Remove `users` and `leads` streams.
- Add `contacts` stream.
- Add support for `cursor` style paging.

## 0.0.3
* Adjust `client.py` to use API `v.1.4`; fix issues w/ `conversations` and `admins` missinng fields; fix `company_attributes` API version error; fix `write_bookmark` issue when scrolling.

- Adjust `client.py` to use API `v.1.4`; fix issues w/ `conversations` and `admins` missinng fields; fix `company_attributes` API version error; fix `write_bookmark` issue when scrolling.

## 0.0.2
* Fix rate limit issue in client.py, intermittently failing in Discover mode.

- Fix rate limit issue in client.py, intermittently failing in Discover mode.

## 0.0.1
* Initial commit

- Initial commit
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
from setuptools import setup, find_packages

setup(name='tap-intercom',
version='0.1.0',
version='0.1.1',
description='Singer.io tap for extracting data from the Intercom API',
author='jeff.huth@bytecode.io',
classifiers=['Programming Language :: Python :: 3 :: Only'],
Expand Down
4 changes: 3 additions & 1 deletion tap_intercom/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,9 @@ def sync_endpoint(client, #pylint: disable=too-many-branches
elif cursor:
pagination = data.get('pages', {}).get('next', {})
starting_after = pagination.get('starting_after', None)
next_url = '{}/{}?starting_after={}'.format(client.base_url, path, starting_after)
if starting_after is None:
break
next_url = '{}/{}?starting_after={}&per_page={}'.format(client.base_url, path, starting_after, limit)
else:
next_url = data.get('pages', {}).get('next', None)

Expand Down