bookmark after each page of conversation records#68
Open
leslievandemark wants to merge 1 commit intomasterfrom
Open
bookmark after each page of conversation records#68leslievandemark wants to merge 1 commit intomasterfrom
leslievandemark wants to merge 1 commit intomasterfrom
Conversation
luandy64
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
A support client was not able to complete the "conversations" stream within 24 hrs, and the tap never advanced. This change adds the existing
to_write_intermediate_bookmarkoption to Conversations to write state after every page of data. It also moves the intermediate state writing to after child stream records are synced, so that the parent stream can't advance past the child stream.Manual QA steps
Risks
Rollback steps