Skip to content

Admins activity logs#28

Open
kv-jokr wants to merge 3 commits intosinger-io:masterfrom
kv-jokr:AdminsActivityLogs
Open

Admins activity logs#28
kv-jokr wants to merge 3 commits intosinger-io:masterfrom
kv-jokr:AdminsActivityLogs

Conversation

@kv-jokr
Copy link
Copy Markdown

@kv-jokr kv-jokr commented Jun 14, 2021

Description of change

Adding admins activity logs stream as documented in https://developers.intercom.com/intercom-api-reference/reference#view-admin-activity-logs

QA steps

  • automated tests passing
  • manual qa steps passing (list below)
    tap-intercom --config config.json --discover > catalog.json > admin activity logs present in JSON File
    tap-intercom --config config.json --catalog catalog.json | singer-check-tap > state_check.json
The output is valid.
It contained 169 messages for 1 streams.

      1 schema messages
    155 record messages
     13 state messages

Details by stream:
+----------------------+---------+---------+
| stream               | records | schemas |
+----------------------+---------+---------+
| admins_activity_logs | 155     | 1       |
+----------------------+---------+---------+

Risks

Rollback steps

  • revert this branch

@leslievandemark
Copy link
Copy Markdown
Contributor

Hi @kv-jokr,

Thank you for the submission. The pr is out of date with master and will need to be updated before we can merge. Notably the streams have been refactored to be class based and admin activity logs will need to follow that format. Heres and up to date comparison: https://github.com/singer-io/tap-intercom/compare/singer-io:master..kv-jokr:AdminsActivityLogs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants