Add tests for DOMException serialization
#110
Merged
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
reviewed
Sep 8, 2025
test.js
Outdated
| t.is(serialized.cause.code, 8); | ||
| // Should preserve DOMException constants | ||
| t.is(serialized.cause.NOT_FOUND_ERR, 8); | ||
| t.is(serialized.cause.SYNTAX_ERR, 12); |
Collaborator
There was a problem hiding this comment.
This sounds weird, why are these constants serialized? Also I don't see any overlap with the request in #107
It's a static prop:
Docs:
Collaborator
There was a problem hiding this comment.
The issue is in the deserialization since the constructor is an unusual (message, codeString), like new DOMException("Something went wrong", "InvalidStateError"), which serialize-error is not set up to do.
Owner
Author
There was a problem hiding this comment.
Yeah, I turned the PR into just being about adding a test.
sindresorhus
force-pushed
the
domexception
branch
from
11a26d8 to
f553c24
Compare
sindresorhus
changed the title
DOMException serialization
fregante
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107 (or rather was already supported)