Read logging configuration file from snippets #301
+27
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPPortier
requested review from
asein-sinch,
matsk-sinch and
rpredescu-sinch
as code owners
Contributor
Dependency Review✅ No vulnerabilities or license issues found.Scanned Manifest Files |
matsk-sinch
approved these changes
Feb 2, 2026
asein-sinch
reviewed
Feb 2, 2026
| return get("SINCH_PHONE_NUMBER"); | ||
| } | ||
|
|
||
| public static void initializeLogger() { |
Contributor
There was a problem hiding this comment.
This can be made private
Comment on lines
+93
to
+95
| LOGGER.config( | ||
| String.format( | ||
| "Error reading '%s' configuration file: %s", LOGGING_CONFIG_FILE, ioe.getMessage())); |
Contributor
There was a problem hiding this comment.
You are using the logger to log an error about the logger that may have not been initialized. Is it ok to do that, or the error message will be invisible?
| try { | ||
| // load a properties file from class path, inside static method | ||
| properties.load(Settings.class.getClassLoader().getResourceAsStream("config.properties")); | ||
| properties.load(Settings.class.getClassLoader().getResourceAsStream(CONFIG_FILE)); |
Contributor
There was a problem hiding this comment.
Nit: instead of throwing a NPE when the file is not found, you may check if the inputStream is not null before loading the properties and log that the config file is not found if null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.