feat: add domain option for custom domain/subdomain routing#10
Open
simulieren wants to merge 1 commit intomainfrom
Open
feat: add domain option for custom domain/subdomain routing#10simulieren wants to merge 1 commit intomainfrom
simulieren wants to merge 1 commit intomainfrom
Conversation
Add a `domain` config option that restricts all server-stats routes
(stats endpoint, debug panel, dashboard) to a specific domain or
subdomain. Uses AdonisJS's native `router.group().domain()` API.
Usage:
defineConfig({ domain: 'admin.example.com' })
defineConfig({ domain: ':tenant.example.com' }) // dynamic
Changes:
- Add `domain?: string` to ServerStatsConfig and ResolvedServerStatsConfig
- Update AdonisRouter type shim with AdonisRouteGroup supporting .domain()
- Pass domain through registerAllRoutes to all sub-registrars
- Stats route wraps in a group when domain is set
- Debug and dashboard route groups conditionally chain .domain()
- Add tests for config resolution and route registration
Closes #9
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
domainconfig option that restricts all server-stats routes to a specific domain or subdomainrouter.group().domain()APIadmin.example.com) and dynamic subdomains (:tenant.example.com)Usage
Changes
ServerStatsConfigandResolvedServerStatsConfiggaindomain?: stringAdonisRoutertype shim updated withAdonisRouteGroupinterface supporting.domain()chaining.domain()when configureddefineConfig()passes domain through to resolved configTest plan
defineConfig({ domain: 'admin.example.com' })passes domain to resolved configdefineConfig({})leaves domain undefined (no behavior change):tenant.example.com) works.domain()when domain is set.domain()called when domain is not configuredCloses #9
🤖 Generated with Claude Code