Skip to content

Feature/simple readdy example#25

Open
blairlyons wants to merge 6 commits intomaintenancefrom
feature/simple-readdy-example
Open

Feature/simple readdy example#25
blairlyons wants to merge 6 commits intomaintenancefrom
feature/simple-readdy-example

Conversation

@blairlyons
Copy link
Copy Markdown

@blairlyons blairlyons commented May 17, 2023

Problem

Simple ReaDDy model in Vivarium for testing live mode.
closes #19

Solution

Updated ReaDDy process and Simularium Emitter in vivarium-collective/vivarium-ReaDDy#1, and wrote test that depends in Vivarium-ReaDDy to simulate 4 particles diffusing in ReaDDy.

Type of change

  • New feature (non-breaking change which adds functionality)

Change summary:

  • add test_readdy_simple.py with a test example
  • update SimulariumEmitter to remove simulator choices and better handle time and particle radii
  • add dependency for Vivarium-ReaDDy
  • update readdy dep to use v2.0.9 (known stable with these models)
  • move monomer ports schema to Vivarium-ReaDDy and use it in ReaddyActinProcess

@blairlyons blairlyons marked this pull request as ready for review May 17, 2023 19:55
@blairlyons blairlyons requested a review from ascibisz May 17, 2023 19:56
particle = monomers["particles"][particle_id]
trajectory["unique_ids"][time_index].append(int(particle_id))
trajectory["type_names"][time_index].append(particle["type_name"])
# HACK needed until simulariumio default display data fix
Copy link
Copy Markdown
Contributor

@ascibisz ascibisz May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the default display data fix got merged in simulariumio, unless there's another default display data bug then the one I'm thinking of?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants