-
Notifications
You must be signed in to change notification settings - Fork 0
Add Ruby 4.0 support #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 4.0 support #112
Conversation
Co-authored-by: addersuk <131964+addersuk@users.noreply.github.com>
|
@copilot Fix this |
Co-authored-by: addersuk <131964+addersuk@users.noreply.github.com>
Fixed in commit 47f80de. Added |
|
@copilot twiglet.gemspec:28 less then 4.1 |
Co-authored-by: addersuk <131964+addersuk@users.noreply.github.com>
|
/dobby version minor |
|
@copilot fix Run bundle exec rake test from /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/rake-13.3.1/lib/rake/rake_test_loader.rb:6:in 'Array#select' from /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/rake-13.3.1/lib/rake/rake_test_loader.rb:6:in '' rake aborted! Command failed with status (1): [ruby -w -I"lib:test" /opt/hostedtoolcache/Ruby/4.0.0/x64/lib/ruby/gems/4.0.0/gems/rake-13.3.1/lib/rake/rake_test_loader.rb "test/test_coverage.rb" "test/error_serialiser_test.rb" "test/formatter_test.rb" "test/hash_extensions_test.rb" "test/logger_test.rb" "test/message_test.rb" "test/validator_test.rb" "examples/rack/request_logger_test.rb" ] /opt/hostedtoolcache/Ruby/4.0.0/x64/bin/bundle:25:in '' Tasks: TOP => test (See full trace by running task with --trace) |
Co-authored-by: addersuk <131964+addersuk@users.noreply.github.com>
Fixed in commit c0b1874. Added |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Ruby 4.0 support to the twiglet gem by addressing compatibility issues with gems that were moved from default to bundled gems in Ruby 4.0, and updating version constraints to reflect tested versions.
Key changes:
- Added
benchmarkandcgias development dependencies to resolve Ruby 4.0 compatibility issues - Updated
required_ruby_versionupper bound from< 3.5to< 4.1to align with tested versions - Added Ruby 4.0 to CI test matrices and updated documentation
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| twiglet.gemspec | Updated Ruby version constraint to < 4.1 and added benchmark and cgi development dependencies |
| test/logger_test.rb | Fixed indentation alignment in test code |
| lib/twiglet/version.rb | Bumped version from 3.14.5 to 3.15.0 for new Ruby support |
| docs/TRUSTED_PUBLISHING.md | Updated documentation to list Ruby 4.0 in supported versions |
| .github/workflows/ruby.yml | Added Ruby 4.0 to test matrix |
| .github/workflows/gem-publish.yml | Added Ruby 4.0 to test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: addersuk <131964+addersuk@users.noreply.github.com>
Fixed in commit 2f2656a. Added |
|
/dobby version minor |
Co-authored-by: Francesca Rodricks <francescarodricks5@gmail.com>
Plan to fix Ruby 4.0 compatibility issue
benchmarkto be explicitly added as a dependencybenchmarkgem to development dependencies in twiglet.gemspeccgigem for Ruby 4.0 compatibility with simplecovSummary
Successfully added Ruby 4.0 support to the twiglet gem with the following changes:
Ruby 4.0 Bundled Gems Compatibility
Ruby 4.0 moved several gems from the standard library to "bundled gems", requiring explicit declaration:
benchmarkgem: Added as development dependency. Required for rubocop to run.cgigem: Added as development dependency. Required for simplecov-html (used by simplecov 0.17.1).minitestgem:>= 5.0in gemspecminitest/mockLoadErrorOther Changes
Updated
required_ruby_version: Changed upper bound from< 5.0to< 4.1to maintain the pattern of only claiming support for tested versions (3.1-4.0).Updated CI workflows: Added Ruby 4.0 to test matrices in both
ruby.ymlandgem-publish.yml.Updated documentation: Updated
TRUSTED_PUBLISHING.mdto reflect Ruby 4.0 support.The gem now properly supports Ruby versions 3.1 through 4.0 while maintaining backward compatibility. All Ruby 4.0 compatibility issues in the CI pipeline have been resolved.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.