fix(xtypes): handle empty strings for all key types#42
Merged
FranciscoKurpiel merged 1 commit intomasterfrom Sep 20, 2025
Merged
fix(xtypes): handle empty strings for all key types#42FranciscoKurpiel merged 1 commit intomasterfrom
FranciscoKurpiel merged 1 commit intomasterfrom
Conversation
This commit extends the `ErrNoValue` fix to all private and public key xtypes to ensure consistent behavior when handling empty string values. The following xtypes were updated: - `xtypes.ECDSAPrivateKey` - `xtypes.Ed25519PrivateKey` - `xtypes.ECDSAPubKey` For each of these types, the `ValueValid` function now returns `types.ErrNoValue` when it encounters an empty string, and the `UnmarshalParam` function has been updated to produce a `nil` key in this case. This change makes the behavior of all key types consistent with the `RSAPrivateKey` implementation, correctly handling empty strings for both optional and required parameters. Comprehensive test suites have been added for each of the affected xtypes (`ecdsa_priv_test.go`, `ed25519_priv_test.go`, `ecdsa_pub_test.go`) to verify this behavior and prevent future regressions. The tests cover valid keys, empty strings, default value fallbacks, and missing required values.
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit extends the
ErrNoValuefix to all private and public key xtypes to ensure consistent behavior when handling empty string values.The following xtypes were updated:
xtypes.ECDSAPrivateKeyxtypes.Ed25519PrivateKeyxtypes.ECDSAPubKeyFor each of these types, the
ValueValidfunction now returnstypes.ErrNoValuewhen it encounters an empty string, and theUnmarshalParamfunction has been updated to produce anilkey in this case.This change makes the behavior of all key types consistent with the
RSAPrivateKeyimplementation, correctly handling empty strings for both optional and required parameters.Comprehensive test suites have been added for each of the affected xtypes (
ecdsa_priv_test.go,ed25519_priv_test.go,ecdsa_pub_test.go) to verify this behavior and prevent future regressions. The tests cover valid keys, empty strings, default value fallbacks, and missing required values.