[ADHOC] Graceful dequeue when branch queue is already removed.#32
Open
siarhei-kisialeu wants to merge 3 commits intomainfrom
Open
[ADHOC] Graceful dequeue when branch queue is already removed.#32siarhei-kisialeu wants to merge 3 commits intomainfrom
siarhei-kisialeu wants to merge 3 commits intomainfrom
Conversation
siarhei-kisialeu
requested review from
FranciscoKurpiel,
aokhotnikovsisu and
bogue1979
siarhei-kisialeu
force-pushed
the
fix/stable-queue-deletion
branch
from
15f5e37 to
e929af9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the "stuck" merge queue.
Graceful Dequeue: Updated Coordinator.Dequeue to return nil instead of an error if the queue or PR no longer exists, treating it as a successful idempotent operation.
Event Handling: Added checks in processPullRequestEvent to handle cases where a PR was already removed by a previous event.