Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangcilint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/setup-go@v6
with:
go-version: "1.25"
lint-version: "v2.7.2"
lint-version: "v2.8.0"
check-latest: true
- uses: actions/checkout@v6
- name: golangci-lint
Expand Down
6 changes: 5 additions & 1 deletion internal/testutils/repotest/repotest.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,11 @@ type Repo struct {

// TaskIDs returns the tasks ids (<AppName>.<TaskName>) of all tasks in the AppCfgs slice
func (r *Repo) TaskIDs() []string {
var result []string
totalTasks := 0
for _, appCfg := range r.AppCfgs {
totalTasks += len(appCfg.Tasks)
}
result := make([]string, 0, totalTasks)

for _, appCfg := range r.AppCfgs {
for _, task := range appCfg.Tasks {
Expand Down
4 changes: 1 addition & 3 deletions pkg/baur/loader.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ func NewLoader(repoCfg *cfg.Repository, gitCommitIDFunc func() (string, error),
// If no specifier is passed all tasks of all apps are returned.
// If multiple specifiers match the same task, it's only returned 1x in the returned slice.
func (a *Loader) LoadTasks(specifier ...string) ([]*Task, error) {
var result []*Task

specs, err := parseSpecs(specifier)
if err != nil {
return nil, err
Expand All @@ -80,7 +78,7 @@ func (a *Loader) LoadTasks(specifier ...string) ([]*Task, error) {
return a.allTasks(apps)
}

result, err = a.allTasks(apps)
result, err := a.allTasks(apps)
if err != nil {
return nil, err
}
Expand Down
Loading