fix(propagation): update OpenTelemetry Baggage API method signatures #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes incompatibility with updated OpenTelemetry Baggage API that changed method signatures from keyword arguments to positional args - Changes `Baggage.value(context:)` to `Baggage.values(context:)` to match current API - Updates `Baggage.set_value()` calls from `set_value(context:, key:, value:)` to `set_value(key, value, context:)` positional argument order - Simplifies span key mapping using SPAN_KEY_MAP lookup instead of case statement - Consolidates duplicate test setup into shared baggage mock context - Updates gem dependencies (faraday-retry, google-protobuf, unicode-emoji)
There was a problem hiding this comment.
Pull request overview
This PR fixes incompatibility with the updated OpenTelemetry Baggage API by updating method signatures and argument orders to match the current API specification.
Changes:
- Updated Baggage API method calls from
value(context:)tovalues(context:)and changedset_valueargument order from keyword args to positional args with optional context - Refactored span key mapping logic by replacing case statement with direct SPAN_KEY_MAP lookup for better maintainability
- Consolidated duplicate test setup into a shared baggage mock context to reduce code duplication
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/langfuse/propagation.rb | Updated Baggage API calls to use new method signatures (values instead of value, positional args for set_value) and simplified span key lookup logic |
| spec/langfuse/propagation_spec.rb | Added shared context for baggage mocks and updated all test calls to match new API signatures |
| Gemfile.lock | Minor version updates for faraday-retry (2.3.2 → 2.4.0), google-protobuf (4.33.0 → 4.33.4), and unicode-emoji (4.1.0 → 4.2.0) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kxzk
deleted the
feature/fix-opentelemetry-baggage-api-method-signatures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DRFixes incompatibility with updated OpenTelemetry Baggage API that changed method signatures from keyword arguments to positional args
WhyBaggage.value(context:)toBaggage.values(context:)to match current APIBaggage.set_value()calls fromset_value(context:, key:, value:)toset_value(key, value, context:)positional argument orderChecklist