Skip to content

Conversation

@drborges
Copy link
Contributor

@drborges drborges commented Dec 16, 2025

Summary

This change increases compatibility with projects that may be using older versions of Faraday (1.x), making the langfuse-ruby SDK more flexible and easier to integrate into existing Ruby projects without forcing a Faraday upgrade.

Key Changes:

  1. Relaxed Faraday dependency constraint (langfuse.gemspec)

    • Changed from ~> 2.0 (only 2.x versions) to >= 1.0 (1.x and above)
    • This allows the gem to work with both Faraday 1.x and 2.x versions
  2. Relaxed Faraday-Retry dependency constraint (langfuse.gemspec)

    • Changed from ~> 2.0 (only 2.x versions) to >= 1.0 (1.x and above)
    • Provides more flexibility for projects using older Faraday versions
  3. Updated Gemfile.lock

    • Updated to reflect the new dependency constraints
    • Added arm64-darwin-24 platform support

closes #38

@kxzk kxzk added the question Further information is requested label Dec 17, 2025
@kxzk kxzk requested a review from NoahFisher December 17, 2025 09:14
@kxzk
Copy link
Collaborator

kxzk commented Dec 19, 2025

Locally tested all variations and seems good to go.

Perhaps constrain upper-bound on deps:

spec.add_dependency "faraday", ">= 1.0", "< 3.0"
spec.add_dependency "faraday-retry", ">= 1.0", "< 3.0"

@drborges
Copy link
Contributor Author

Good call @kxzk. Thanks.

@benlangfeld
Copy link

@kxzk @NoahFisher Happy new year. Could we please get this merged?

@kxzk kxzk merged commit 5380bc9 into simplepractice:main Jan 14, 2026
10 checks passed
drborges added a commit to drborges/langfuse-ruby that referenced this pull request Jan 14, 2026
…ture/stale-while-revalidate

* 'main' of github.com:simplepractice/langfuse-rb:
  Allow a wider range of faraday versions to increase gem compatibility with older projects (simplepractice#37)
  docs(contributing): update file paths and pr template guidance
  chore(pr-template): standardize heading format for consistency
  chore: add pull request template
  docs(changelog): consolidate unreleased changes into v0.2.0 release
  chore(release): bump version to 0.2.0
  chore: release v0.2.0
  docs(changelog): restructure to reflect incremental releases
  docs(readme): improve visual hierarchy and readability
  docs(readme): improve contribution guidelines presentation
  docs: remove redundant license section from readme
  docs(readme): update gem badge and fix formatting
  Add create and update methods to client API (simplepractice#36)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support older versions of Faraday

4 participants