Skip to content

WIP: Property validation #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
takesson wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −0
Open

WIP: Property validation #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/main/java/se/simonsoft/cms/item/commit/CmsCommit.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
package se.simonsoft.cms.item.commit;

import java.util.Map;

import se.simonsoft.cms.item.CmsItemLock;
import se.simonsoft.cms.item.CmsItemLockCollection;
import se.simonsoft.cms.item.CmsItemPath;
Expand Down Expand Up @@ -59,4 +61,25 @@ public interface CmsCommit {
*/
public void unlock(CmsItemLock... lock);


// Better in CmsItemProperties?
// validateProperty
// validateRevisionProperties
// Reserved names in revprops.
// Require prefix.
// Limit length, parameter and default definitions?
public static void validateProperties(Map<String, String> properties) {
if (properties == null) {
throw new IllegalArgumentException("Properties must not be null");
}
if (properties.containsKey("cms:revision")) {
throw new IllegalArgumentException("Property 'cms:revision' is reserved and must not be set");
}
if (properties.containsKey("cms:commit")) {
throw new IllegalArgumentException("Property 'cms:commit' is reserved and must not be set");
}
if (properties.containsKey("cms:author")) {
throw new IllegalArgumentException("Property 'cms:author' is reserved and must not be set");
}
}
}