Reverse mapping: uses real Polymer splice but emulates backbone add#6
Merged
Reverse mapping: uses real Polymer splice but emulates backbone add#6
Conversation
…ting attributes, no splices support
…t on backbone behavior
… restrictions on .add we should continue the collection-set-patch branch
…t also want to swith the mock element for a real element.
solsson
added a commit
that referenced
this pull request
Oct 8, 2015
Reverse mapping: uses real Polymer splice but emulates backbone add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix avoids overriding the elaborate Collection.set method in Backbone, but is on the other hand severely restricted on the types of add operations it allows.
For a generic solution we should work on #5. Ideally Backbone would expose Collection's internal
splicemethod for overriding.