Skip to content

FEAT: make loglevel configurable#129

Merged
JBorrow merged 2 commits intomainfrom
disable-logging
Feb 5, 2026
Merged

FEAT: make loglevel configurable#129
JBorrow merged 2 commits intomainfrom
disable-logging

Conversation

@ColmTalbot
Copy link
Collaborator

This PR makes the log level configurable in the pipeline. This is basically following the method described in https://www.structlog.org/en/stable/bound-loggers.html#filtering-by-log-levels.

@ColmTalbot ColmTalbot requested review from JBorrow and axf295 January 23, 2026 14:47
@ColmTalbot ColmTalbot added the enhancement New feature or request label Jan 23, 2026
@JBorrow
Copy link
Member

JBorrow commented Jan 23, 2026

Looks good but make the default log level DEBUG for this stage of the project. Also, how are these configurable in practice? export SOTRPLIB_LOG_LEVEL=DEBUG?

@JBorrow
Copy link
Member

JBorrow commented Jan 27, 2026

Just checking in to see if you managed to test whether this correctly reads from environment variables?

@ColmTalbot
Copy link
Collaborator Author

Just checking in to see if you managed to test whether this correctly reads from environment variables?

I verified that SOTRP_LOG_LEVEL={DEBUG,INFO,WARNING} (case insensitive, but note SOTRP not SOTRPLIB) works.

@JBorrow
Copy link
Member

JBorrow commented Feb 5, 2026

That's correct. Thank you!

@JBorrow JBorrow merged commit bf66c2c into main Feb 5, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants