Remove boost dependency #229
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert boost::python bindings to nanobind. Keep interfaces as close as possible to the existing ones. In particular, the direct CPython interface is NOT replaced with nanobind.ndarray<>. Mainly only nb::object and nb::cast are used. - Replace large, fragile, ad-hoc setup.py with direct running of cmake from pyproject.toml, using scikit-build-core. - Incorporate a local copy of boost/math/quaternion.hpp with trig functions removed to lift any dependency on other boost parts. - Clean up python imports (which had absolute imports of "so3g") and replace with relative imports within the package.
…ping with scikit-build-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #212. This work performs the minimal replacement of boost::python with pybind11. It also:
Replaces large, fragile, ad-hoc setup.py with direct running of cmake from pyproject.toml, using scikit-build-core.
Incorporates a local copy of boost/math/quaternion.hpp with trig functions removed to lift any dependency on other boost parts.
Cleans up python imports (which had absolute imports of "so3g") and replaces with relative imports within the package.
Moves the python package into a
python/so3gsubdirectory, which makes discovery by the build system easier.