fish: use auto theme for automatic light/dark switching #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR updates the Fish shell theme configuration to leverage Fish 4.3+'s new auto theme functionality for automatic light/dark mode switching. Instead of manually calling fish_config theme choose in the event handler, the theme is now set once to "Rosé Pine Moon Auto", which handles theme switching automatically.
Changes:
- Set the theme to "Rosé Pine Moon Auto" at configuration load time
- Removed manual theme switching logic from the
__so_apply_themefunction - Removed the
theme_variant_capitalizedvariable which is no longer needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simono
force-pushed
the
fish-auto-theme
branch
from
a0a8b0b to
ec571b1
Compare
Fish 4.3+ auto themes handle the switching automatically, removing the need to call fish_config in the event handler. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
simono
force-pushed
the
fish-auto-theme
branch
from
ec571b1 to
d686a75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fish 4.3+ auto themes handle the switching automatically, removing the need to call fish_config in the event handler.
Depends on rose-pine/fish#6