Merged
Conversation
…ate ESLint config
Fixes `Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './v4' is not defined by "exports" in /Users/simon.knittel/Documents/personal/projects/sam/app/node_modules/zod-validation-error/package.json` caused by `eslint-config-next` and `eslint-plugin-react-hooks`
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears aimed at hardening and polishing the app for a production deployment by centralizing environment configuration, tightening request/schema validation, and aligning tooling/CI behavior.
Changes:
- Switches some runtime configuration to use the app’s typed
envmodule (notably for OpenAI and the tRPC base URL). - Updates multiple Zod schemas (enum handling and new max-length/optionality constraints).
- Tidies formatting/config and makes CI Prettier checks blocking; pins/updates a few dev dependencies.
Reviewed changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| app/src/server/api/routers/ai.ts | Uses typed app env for OpenAI API key access. |
| app/src/proxy.ts | Rewords authentication-related comment (now JSDoc-style). |
| app/src/modules/tasks/actions/createTask.ts | Updates Zod enum validation for task fields. |
| app/src/modules/profit-distribution/actions/updateParticipantAttribute.ts | Adds an attempted guard limiting number of submitted form keys. |
| app/src/modules/notifications/actions/updateMyNotificationSettings.ts | Adds an attempted guard limiting number of submitted form keys. |
| app/src/modules/common/utils/api.ts | Changes tRPC base URL resolution to env.BASE_URL. |
| app/src/modules/common/components/CreateContext.tsx | Formatting-only changes to dynamic imports. |
| app/src/modules/citizen/actions/updateRoleAssignment.ts | Adds an attempted guard limiting number of submitted form keys. |
| app/src/modules/career/nodes/RoleCitizens/server/updateFlowSchema.ts | Updates Zod enum validation. |
| app/src/modules/career/nodes/RoleCitizens/client/schema.ts | Updates Zod enum validation. |
| app/src/modules/career/nodes/Role/server/updateFlowSchema.ts | Updates Zod enum validation. |
| app/src/modules/career/nodes/Role/client/schema.ts | Updates Zod enum validation. |
| app/src/modules/career/nodes/Markdown/server/updateFlowSchema.ts | Tightens Markdown schema (max length + enum). |
| app/src/modules/career/nodes/Markdown/client/schema.ts | Tightens Markdown schema (max length + enum + optional backgroundColor). |
| app/src/modules/auth/components/AdminEnabler.tsx | Adds samesite=lax attribute to the admin toggle cookie. |
| app/src/env.ts | Updates URL validation to Zod v4 z.url(). |
| app/src/app/preview-channel/_opengraph-image.tsx | Formatting-only JSX simplification. |
| app/src/app/opengraph-image.tsx | Formatting-only JSX simplification. |
| app/src/app/manifest.ts | Reorders imports. |
| app/src/app/icon.tsx | Formatting-only JSX simplification. |
| app/src/app/dogfight-trainer/opengraph-image.tsx | Formatting-only JSX simplification. |
| app/src/app/api/health/throw/route.ts | Removes the “throw” health route. |
| app/postcss.config.cjs | Normalizes quotes (Prettier). |
| app/package.json | Pins eslint-plugin-react-compiler; adds zod-validation-error. |
| app/package-lock.json | Lockfile updates for dependency changes. |
| app/eslint.config.mjs | Enables react-compiler recommended config; adjusts plugin wiring. |
| app/.devcontainer/devcontainer.json | Formatting-only (forwardPorts array). |
| .github/workflows/validate-app.yml | Makes Prettier check blocking (removes continue-on-error). |
Files not reviewed (1)
- app/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/modules/profit-distribution/actions/updateParticipantAttribute.ts
Outdated
Show resolved
Hide resolved
app/src/modules/notifications/actions/updateMyNotificationSettings.ts
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 31 out of 32 changed files in this pull request and generated 11 comments.
Files not reviewed (1)
- app/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only merge using a merge commit!