Skip to content

Production deployment#1930

Merged
simonknittel merged 10 commits intomainfrom
develop
Mar 1, 2026
Merged

Production deployment#1930
simonknittel merged 10 commits intomainfrom
develop

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Mar 1, 2026

Only merge using a merge commit!

@vercel
Copy link

vercel bot commented Mar 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sam Ready Ready Preview Mar 1, 2026 3:33pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a reusable CitizenPopover tooltip across the app, backed by new tRPC endpoints, and adds hover-delay support to the shared Popover behavior to reduce accidental popover opens.

Changes:

  • Add CitizenPopover client component and wrap many citizen links across modules with it.
  • Add new tRPC queries for fetching assignable roles and citizen popover data.
  • Extend shared Popover/useMouseEnterCounter to support hoverDelay and open-state callbacks; update UI styling in a few shared components.

Reviewed changes

Copilot reviewed 24 out of 25 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
app/src/server/api/routers/roles.ts Adds getAssignableRoles tRPC endpoint.
app/src/server/api/routers/citizens.ts Adds getCitizenById tRPC endpoint used by the popover.
app/src/modules/citizen/queries.ts Adds getCitizenPopoverById query helper used by the new endpoint.
app/src/modules/citizen/components/CitizenPopover.tsx New tooltip component that fetches citizen summary + roles on open.
app/src/modules/common/components/Popover.tsx Adds hoverDelay and onOpenChange wiring to Radix popover open state.
app/src/modules/common/utils/useMouseEnterCounter.ts Implements delayed hover-open logic for popovers.
app/src/modules/citizen/components/roles/Roles.tsx Simplifies “can edit roles” logic and updates AddRoles usage.
app/src/modules/citizen/components/roles/AddRoles.tsx Fetches assignable roles via tRPC on-demand when modal opens.
app/src/modules/common/components/CitizenLink.tsx Wraps citizen link with CitizenPopover.
app/src/modules/users/components/Table.tsx Wraps “Spynet” link with CitizenPopover.
app/src/modules/spynet/components/ActivityTile/mapOrganizationMembershipHistoryEntries.tsx Wraps citizen handle links with CitizenPopover.
app/src/modules/silc/components/SilcTransactionsTableClient.tsx Wraps citizen link with CitizenPopover.
app/src/modules/penalty-points/components/PenaltyEntry.tsx Wraps “created by” citizen link with CitizenPopover.
app/src/modules/penalty-points/components/AllEntriesTableClient.tsx Wraps citizen link with CitizenPopover.
app/src/modules/organizations/components/MembershipsTile.tsx Wraps member citizen link with CitizenPopover.
app/src/modules/organizations/components/ActivityTile.tsx Wraps citizen links with CitizenPopover.
app/src/modules/events/components/ParticipantsTab.tsx Wraps manager/participant citizen links with CitizenPopover.
app/src/modules/roles/components/SingleRoleBadge.tsx Adjusts popover sizing and adds hover delay for role badge tooltip.
app/src/modules/common/components/CopyToClipboard.tsx Updates tooltip styling.
app/src/modules/common/components/Button.tsx Adds mono/uppercase styling to base button class.
app/src/modules/changelog/assets/2026-03-01-citizen-popover.png Adds screenshot asset for changelog entry.
app/src/app/app/changelog/page.tsx Adds changelog entry and adjusts some image loading + formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@socket-security
Copy link

socket-security bot commented Mar 1, 2026

@socket-security
Copy link

socket-security bot commented Mar 1, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
Critical CVE: npm form-data uses unsafe random function in form-data for choosing boundary

CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL)

Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4

Patched version: 4.0.4

From: bun-packages/packages/email-function/package.jsonnpm/form-data@4.0.2

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/form-data@4.0.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 28 out of 30 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • app/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2026

@simonknittel simonknittel enabled auto-merge March 1, 2026 15:30
@simonknittel simonknittel merged commit f59bbe2 into main Mar 1, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants