Skip to content

refactor(Lambda): make use of Parameter Store #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonknittel merged 1 commit into from
Dec 7, 2025

refactor(Lambda): make use of Parameter Store

3706e3c
Select commit
Loading
Failed to load commit list.
Merged

refactor(Lambda): make use of Parameter Store #1849

refactor(Lambda): make use of Parameter Store
3706e3c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Dec 7, 2025 in 39s

Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 9 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/TaskAssignmentUpdated.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9bm9H2sdBaENyVW&open=AZr4f9bm9H2sdBaENyVW&pullRequest=1849

Check warning on line 82 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/EventUpdated.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`citizenRoleIds` should be a `Set`, and use `citizenRoleIds.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9bd9H2sdBaENyVV&open=AZr4f9bd9H2sdBaENyVV&pullRequest=1849

Check warning on line 67 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/PenaltyEntryCreated.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`roleIdsOfCitizen` should be a `Set`, and use `roleIdsOfCitizen.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9bT9H2sdBaENyVU&open=AZr4f9bT9H2sdBaENyVU&pullRequest=1849

Check warning on line 78 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/SilcTransactionsCreated.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`citizenRoleIds` should be a `Set`, and use `citizenRoleIds.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9cB9H2sdBaENyVY&open=AZr4f9cB9H2sdBaENyVY&pullRequest=1849

Check warning on line 82 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/EventLineupEnabled.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`citizenRoleIds` should be a `Set`, and use `citizenRoleIds.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9bJ9H2sdBaENyVT&open=AZr4f9bJ9H2sdBaENyVT&pullRequest=1849

Check warning on line 75 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/RoleAdded.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`roleIdsOfCitizen` should be a `Set`, and use `roleIdsOfCitizen.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9cz9H2sdBaENyVd&open=AZr4f9cz9H2sdBaENyVd&pullRequest=1849

Check warning on line 9 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/TaskCreated.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9cL9H2sdBaENyVZ&open=AZr4f9cL9H2sdBaENyVZ&pullRequest=1849

Check failure on line 53 in pnpm-monorepo/apps/lambda/src/notification-router/web-push.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 24 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9c-9H2sdBaENyVe&open=AZr4f9c-9H2sdBaENyVe&pullRequest=1849

Check warning on line 72 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/EventCreated.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`citizenRoleIds` should be a `Set`, and use `citizenRoleIds.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9cV9H2sdBaENyVa&open=AZr4f9cV9H2sdBaENyVa&pullRequest=1849

Check warning on line 20 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/ProfitDistributionPayoutDisbursed.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9Ye9H2sdBaENyVS&open=AZr4f9Ye9H2sdBaENyVS&pullRequest=1849

Check warning on line 82 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/EventDeleted.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

`citizenRoleIds` should be a `Set`, and use `citizenRoleIds.has()` to check existence or non-existence. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9cf9H2sdBaENyVb&open=AZr4f9cf9H2sdBaENyVb&pullRequest=1849

Check warning on line 11 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/ProfitDistributionPayoutStarted.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9cp9H2sdBaENyVc&open=AZr4f9cp9H2sdBaENyVc&pullRequest=1849

Check warning on line 10 in pnpm-monorepo/apps/lambda/src/notification-router/type-handlers/TaskAssignmentUpdated.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9bm9H2sdBaENyVX&open=AZr4f9bm9H2sdBaENyVX&pullRequest=1849

Check warning on line 13 in pnpm-monorepo/apps/lambda/src/midnight-automations.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9dT9H2sdBaENyVg&open=AZr4f9dT9H2sdBaENyVg&pullRequest=1849

Check warning on line 5 in pnpm-monorepo/apps/lambda/src/midnight-automations/countShips.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9dK9H2sdBaENyVf&open=AZr4f9dK9H2sdBaENyVf&pullRequest=1849

Check warning on line 21 in pnpm-monorepo/apps/lambda/src/scrape-discord-events.ts

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this commented out code. 

See more on https://sonarcloud.io/project/issues?id=simonknittel_sinister-incorporated&issues=AZr4f9de9H2sdBaENyVh&open=AZr4f9de9H2sdBaENyVh&pullRequest=1849
View more details on SonarQubeCloud