Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces npm with pnpm across the repository to standardize dependency management and command usage. Key changes include:
- Updating documentation in docs/setup-local-machine.md and docs/changing-database-schema.md with pnpm commands.
- Adjusting project scripts, CI workflows, and configuration files to use pnpm.
- Modifying form data handling in fleet components and cleaning up type assertions in task actions.
Reviewed Changes
Copilot reviewed 12 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/setup-local-machine.md | Updated dependency installation and prisma migration steps to use pnpm commands |
| docs/changing-database-schema.md | Replaced npm-based prisma commands with pnpm commands for schema updates |
| app/src/tasks/actions/completeTask.tsx | Removed non-null assertion from task.repeatable arithmetic operation |
| app/src/fleet/components/EditableShipName.tsx | Changed form data handling from optional chaining to direct type assertion |
| app/src/fleet/components/EditableSeriesName.tsx | Changed form data handling from optional chaining to direct type assertion |
| app/src/fleet/components/EditableManufacturerName.tsx | Changed form data handling from optional chaining to direct type assertion |
| app/src/env.ts | Added a new environment flag “skipValidation” |
| app/src/app/privacy/page.tsx | Minor formatting changes to improve readability |
| app/pnpm-workspace.yaml | Introduced pnpm workspace configuration for dependency hoisting |
| .github/workflows/validate-app.yml | Migrated CI configuration to use pnpm for installation, linting, and testing |
Files not reviewed (8)
- .vscode/settings.json: Language not supported
- app/.devcontainer/postCreateCommand.sh: Language not supported
- app/.eslintrc.json: Language not supported
- app/.prettierignore: Language not supported
- app/.vscode/launch.json: Language not supported
- app/.vscode/tasks.json: Language not supported
- app/package.json: Language not supported
- git-hooks/post-merge.sh: Language not supported
Comments suppressed due to low confidence (1)
app/src/tasks/actions/completeTask.tsx:234
- Removing the non-null assertion operator could lead to potential runtime errors if task.repeatable is undefined. Please confirm that task.repeatable is always defined before performing the subtraction.
repeatable: task.repeatable - 1,
simonknittel
force-pushed
the
feature/pnpm-2
branch
from
b5c656d to
c2a2462
Compare
simonknittel
force-pushed
the
feature/pnpm-2
branch
from
c2a2462 to
8960fd2
Compare
simonknittel
force-pushed
the
feature/pnpm-2
branch
from
8960fd2 to
4ecf864
Compare
|
simonknittel
force-pushed
the
develop
branch
2 times, most recently
from
53aff1a to
5aa0b44
Compare
simonknittel
force-pushed
the
develop
branch
from
b08791e to
9fb841d
Compare
simonknittel
force-pushed
the
develop
branch
5 times, most recently
from
3323642 to
439ff89
Compare
simonknittel
force-pushed
the
develop
branch
3 times, most recently
from
2103a69 to
8167784
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.