Open
Conversation
line 59 and line 113
Imd afix
simonellistonball
requested changes
Nov 28, 2018
Owner
simonellistonball
left a comment
simonellistonball
left a comment
There was a problem hiding this comment.
Why the additional copies of the java files in the root? Are the real changes just in the package based diffs?
| if (signed) { | ||
| return String.valueOf( | ||
| ((dst[0] & 0x8000) == 0x8000 ? -1 : 1) * bytesToLong(dst, len > 0 ? len : bytes)); | ||
| return String.valueOf(bytesToLong(dst, len > 0 ? len : bytes)); |
There was a problem hiding this comment.
Is there a reason to remove the 0x8000 check here?
Author
|
The only change is in IANA_IPFIX_TYPES.java and NetflowParser.java. No other changes
Vijay Narayanan
Partner Solution Engineer|Hortonworks
M:+919845445812
From: Simon Elliston Ball <notifications@github.com>
Reply-To: simonellistonball/nifi-netflow <reply@reply.github.com>
Date: Wednesday, November 28, 2018 at 6:47 PM
To: simonellistonball/nifi-netflow <nifi-netflow@noreply.github.com>
Cc: Jayasankar Vijay Narayanan <jnarayanan@hortonworks.com>, Author <author@noreply.github.com>
Subject: Re: [simonellistonball/nifi-netflow] these are the IMDA changes (#1)
@simonellistonball requested changes on this pull request.
Why the additional copies of the java files in the root? Are the real changes just in the package based diffs?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#1 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Ae-ENiAU84uG1DDJEEcWmQT5lIXuql6vks5uzozqgaJpZM4Y28y8>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
two changes to IANA_IPFIX_TYPES.java and 1 change to NetflowParser.java