Changes for ruby 1.9.3 and puppet 3.x#2
Open
johnburns320 wants to merge 2 commits intosimondean:masterfrom
Open
Changes for ruby 1.9.3 and puppet 3.x#2johnburns320 wants to merge 2 commits intosimondean:masterfrom
johnburns320 wants to merge 2 commits intosimondean:masterfrom
Conversation
Ruby 1.9.3 no longer provides an each method for String objects. Switching to use each_line method. @onyxmaster submitted Issue #1 providing original fix.
Permissions property on the net_share type was trying to munge an array of values using a collect method deprecated in Puppet 3.x. Changed munge block on permissions property to treat each value as a string. @onyxmaster submitted Issue #1 providing original fix.
|
@simondean is this project still alive? would you conciser transferring the ownership or fixing up the code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request submitting fix originally provided by @onyxmaster in Issue #1.