-
Notifications
You must be signed in to change notification settings - Fork 0
implement button and logic for canceling reservation request #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lian-jung
wants to merge
26
commits into
main
Choose a base branch
from
cancel-reservation-request
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,352
−205
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f238ee9
implement confirmation button and logic for canceling reservation req…
lian-jung a412aec
added additional test coverage and verify only reserver can cancel re…
lian-jung 3b356d7
resolved sourcery comment to remove deduplication in stories files
lian-jung e08f84b
added correct validation for reserver canceling a reservation request…
lian-jung 262a49b
upgrade storybook in ui-sharethrift package.json and cellix vitest-co…
lian-jung 0b41ce9
Merge branch 'main' into cancel-reservation-request
lian-jung 67e3e13
changed storybook version to 9.1.17 in ui-sharethrift, cellix ui-core…
lian-jung fccbca6
removed unused exported types
lian-jung c00d028
resolve sonarqube flagging low issues
lian-jung a6220c7
added additional code coverage for sonarqube and addressed sourcery c…
lian-jung 2da502a
remove test-utils stories file
lian-jung 8cde1ca
addressed sourcery comments for duplication in stories/test files
lian-jung 0ab6e76
removed unused exports error from knip
lian-jung 77b087a
addressed sourcery feedback
lian-jung e2fdec9
Merge main branch - resolved conflicts by taking theirs for storybook…
lian-jung dcc5a05
Refactor stories and extract shared CancelReservationPopconfirm compo…
lian-jung 756a721
more sourcery comments
lian-jung 1637b6a
remove duplicated popconfirm util logic
lian-jung dbbe3b0
Merge main into cancel-reservation-request
lian-jung 72316e5
Fix snyk vulnerabilities: upgrade express to 4.22.0 and override qs t…
lian-jung d2d8d02
Revert security fixes - will address separately
lian-jung 863bc12
Merge remote-tracking branch 'origin/main' into cancel-reservation-re…
lian-jung a04257e
setting state in cancel reservation request handles permission checks…
lian-jung 77570b0
Merge main into cancel-reservation-request branch
lian-jung fdc12fa
update react-router package to 7.12.0 to address package vulnerabilit…
lian-jung dafb758
increased code coverage
lian-jung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For snyk, look at this pr for what was required in this file https://github.com/simnova/sharethrift/pull/338/files
anything else i believe was upgradable, my pr is good for vulnerabilities