Skip to content

Remove default exports in react components that display content #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gidich wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove default exports in react components that display content #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ef7e9b
Remove default exports in react components that display content
gidich Oct 6, 2024
0531400
Update GitHub Copilot settings for code generation instructions
gidich Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ownercommunity.code-workspace
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
],
"settings": {
"debug.internalConsoleOptions": "neverOpen",
"github.copilot.chat.experimental.codeGeneration.instructions": [
"github.copilot.chat.codeGeneration.instructions": [
{
"file": "rules.md"
},
}
]
}
}
4 changes: 1 addition & 3 deletions ui-community/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { uiConfig, staffConfig } from './config/odic-config';
import MaintenanceMessageProvider from './components/shared/maintenance-message';
import { useFeatureFlags } from './components/shared/feature-flag-react-lite';

function App() {
Copy link
Contributor

@sourcery-ai sourcery-ai bot Oct 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (review_instructions): Missing props interface for App component

Please define an interface named 'AppProps' for the component's props, even if it's currently empty. Refer to '002-ui-tsx-files.md' for more information on prop interfaces.

Review instructions:

Path patterns: ui-*/**/*.tsx

Instructions:

  • The exported react component name should match the container name (the file name should be kabob-cased, and the component name should be PascalCased) unless the file name is index.tsx, then the component name should match the parent folder name.
  • The component should be a functional component.
  • An interface or type should be defined for the component's props, named <ComponentName>Props.
    • the props should refer to data only by the fragment name or graphql input type name
  • Any use of the AntDesign Table should leverage TableColumnsType and must specify the type of the data (usually the fragment type)
  • Any use of the AntDesign useForm hook must specify the type of the form data (usually the GraphQL input type)
  • If any of the above rules are broken, direct the developer to refer to the document file named 002-ui-tsx-files.md
  • An interface should be defined for the component's props, named <ComponentName>Props.
    • the props should refer to data only by the fragment name or graphql input type name
  • Any use of the AntDesign Table should leverage TableColumnsType and must specify the type of the data (usually the fragment type)
  • Any use of the AntDesign useForm hook must specify the type of the form data (usually the GraphQL input type)
  • If any of the above rules are broken, direct the developer to refer to the document file named 002-ui-tsx-files.md

export function App() {
const { GetFeatureFlagByName } = useFeatureFlags();

let maintenanceInfo = {
Expand Down Expand Up @@ -91,5 +91,3 @@ function App() {
</Routes>
);
}

export default App;
2 changes: 1 addition & 1 deletion ui-community/src/components/layouts/accounts/components/user-info.container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ export const UserInfoContainer: React.FC<any> = () => {
</div>
)

}
}
2 changes: 1 addition & 1 deletion ui-community/src/components/layouts/admin/components/roles-detail.container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,4 @@ export const RolesDetailContainer: React.FC<RolesDetailContainerProps> = (props)
error={roleError ?? updateError}
/>
);
};
};
2 changes: 1 addition & 1 deletion ui-community/src/components/layouts/admin/components/service-tickets-detail.container.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,4 +178,4 @@ export const ServiceTicketsDetailContainer: React.FC<ServiceTicketsDetailContain
} else {
return <div>No Data...</div>;
}
};
};
Loading