Allow eco mode access for non-heating split ACs#474
Open
Jyers wants to merge 2 commits intosimbaja:masterfrom
Open
Allow eco mode access for non-heating split ACs#474Jyers wants to merge 2 commits intosimbaja:masterfrom
Jyers wants to merge 2 commits intosimbaja:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On split AC units, the current implementation reserves the home assistant "auto" mode of the climate entity for the real auto mode implemented on devices with heating support. However, in the absence of heating, these units still have an eco or energy saver mode which could utilize the currently unused home assistant auto setting (just like the window ACs do).
This implementation has the following logic:
Split AC:
Has heating -> HA auto mode links to device auto mode -> exactly the same as before
No heating -> HA auto mode links to device energy saver mode -> additional functionality unlocked for these devices