Avoid returning None for oven target_temperature#457
Open
bxthomas wants to merge 1 commit intosimbaja:masterfrom
Open
Avoid returning None for oven target_temperature#457bxthomas wants to merge 1 commit intosimbaja:masterfrom
bxthomas wants to merge 1 commit intosimbaja:masterfrom
Conversation
When the oven is off, current_cook_setting.temperature may be None. This causes target_temperature to return None, which breaks downstream consumers that expect a numeric value (e.g. Google Assistant device state serialization). Return a valid numeric temperature instead of None so the oven entity always exposes a stable target_temperature value. This prevents Google Assistant queries from failing with: TypeError: float() argument must be a string or a real number, not 'NoneType'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the oven is off, current_cook_setting.temperature may be None. This causes target_temperature to return None, which breaks downstream consumers that expect a numeric value (e.g. Google Assistant device state serialization).
Return a valid numeric temperature instead of None so the oven entity always exposes a stable target_temperature value.
This prevents Google Assistant queries from failing with: TypeError: float() argument must be a string or a real number, not 'NoneType'