Skip to content

Properly await for terminated processes #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jprotopopov-ut wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Properly await for terminated processes #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c75350e
Await for all sanitizer subprocesses to terminate before closing the …
jprotopopov-ut Aug 12, 2025
b4ca2ce
Ignore ProcessLookupError which rarely arises upon sending SIGKILL up…
jprotopopov-ut Aug 12, 2025
d38cbf0
Add --timeout parameter to terminate all sanitizer processes after sp…
jprotopopov-ut Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions sv-sanitizers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def parse_args():
parser.add_argument("-d", "--data-model", type=str, choices=["ILP32", "LP64"], default="LP64")
parser.add_argument("program", type=str)
parser.add_argument("-j", "--jobs", type=int, default=1)
parser.add_argument("-t", "--timeout", type=int, required=False)
parser.add_argument("-v", "--version", action="version", version=VERSION)

args = parser.parse_args()
Expand Down Expand Up @@ -129,6 +130,7 @@ async def run_one(args, executable):
else:
return None
finally:
await process.wait()
processes.remove(process)

async def run_worker(args, executable):
Expand All @@ -140,14 +142,18 @@ async def run_worker(args, executable):

async def run(args, executable):
tasks = [asyncio.create_task(run_worker(args, executable), name=f"worker-{i}") for i in range(args.jobs)]
done, pending = await asyncio.wait(tasks, return_when="FIRST_COMPLETED")
done, pending = await asyncio.wait(tasks, return_when="FIRST_COMPLETED", timeout=args.timeout)
global stop
stop = True
for process in processes:
process.kill()
try:
process.kill()
except ProcessLookupError as ex:
pass
for task in pending:
task.cancel()
return done.pop().result()
await asyncio.wait(tasks)
return done.pop().result() if done else ('true', b'')

def generate_witness(args, result):
if args.property == "no-data-race":
Expand Down