Fix logic for service type and loadBalancerIP rendering

[JakobStadlhuber]

Reverse incorrect conditions for service.ingress.enabled. Ensures that service type and loadBalancerIP are appropriately configured based on the ingress setting, aligning with the expected configuration behavior.

[JakobStadlhuber]

@sim500 could you also please merge this back in your current open pr of the offical repo

[sim500]

Thank you @JakobStadlhuber . I assigned @AlePini to review this PR and eventual others PRs to the original project. Since the majority of refactoring has been done by him.

[AlePini]

Hi @JakobStadlhuber, thanks for you contribution!

I'm not quite sure about your issue here: when you want to access your application via Ingress, the corresponding service should be ClusterIP. Load balancing is already handled by the Ingress-Controller.

I think a better fix for this is to set service type based on passed values:

...
spec:
  type: {{ .Values.service.type }}
  
  {{- if eq .Values.service.type "LoadBalancer" }}
  loadBalancerIP: {{ .Values.global.externalIP }}
  externalTrafficPolicy: Cluster
  {{- end }}
...

Let me know it this works for you :)

[JakobStadlhuber]

@AlePini that works too. I will change the PR. thank you for your contribution.

[AlePini]

@JakobStadlhuber I'll also add this change to this PR hoppscotch/pull/13

I hope they will merge these changes quickly 😅