Custom manifest.json and fixed some issues#90
Open
Dhinagaran-s wants to merge 3 commits intosilviolleite:masterfrom
Open
Custom manifest.json and fixed some issues#90Dhinagaran-s wants to merge 3 commits intosilviolleite:masterfrom
Dhinagaran-s wants to merge 3 commits intosilviolleite:masterfrom
Conversation
|
hi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#37 Miss content_type on manifest.json
Fixed with custom file option like serviceworker, by setting a path variable
PWA_MANIFEST_PATHat the settings.py#38 sizes not in html
Corrected the
README.mdfile for the tutorial to use django-pwa#59 Custom manifest.json
Fixed with custom file option like serviceworker, by setting a path variable
PWA_MANIFEST_PATHat the settings.py#70 Short Name Setting Not added
Created a variable to choose the
SHORT NAMEby using the variablePWA_APP_SHORT_NAME