Fix sizes property name to size in README#80
Open
PetrDlouhy wants to merge 1 commit intosilviolleite:masterfrom
Open
Fix sizes property name to size in README#80PetrDlouhy wants to merge 1 commit intosilviolleite:masterfrom
PetrDlouhy wants to merge 1 commit intosilviolleite:masterfrom
Conversation
Fix silviolleite#38 The `sizes` property name in README doesn't match with the code, where is it named `size`: https://github.com/silviolleite/django-pwa/blob/0ff60e7afaf23d6883d593554b93e54bb56e41fe/pwa/templates/pwa.html#L19
Contributor
|
I believe this should be fixed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #38
The
sizesproperty name in README doesn't match with the code, where is it namedsize:django-pwa/pwa/templates/pwa.html
Line 19 in 0ff60e7