Skip to content

Fix service worker script URL if app is not mounted in root of webserver#64

Open
kygoh wants to merge 2 commits intosilviolleite:masterfrom
kygoh:master
Open

Fix service worker script URL if app is not mounted in root of webserver#64
kygoh wants to merge 2 commits intosilviolleite:masterfrom
kygoh:master

Conversation

@kygoh
Copy link

@kygoh kygoh commented Feb 28, 2021

... specifically when building and deploying server-less Django with zappa

@codecov-io
Copy link

Codecov Report

Merging #64 (4d04117) into master (0ff60e7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #64   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines           50        52    +2     
=========================================
+ Hits            50        52    +2     
Impacted Files Coverage Δ
pwa/app_settings.py 100.00% <100.00%> (ø)
pwa/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ff60e7...4d04117. Read the comment docs.

Copy link

@samueljsb samueljsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants