Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/pwa/_compat.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import django

if django.VERSION >= (5, 1):
from django.contrib.auth.decorators import login_not_required
else:

def login_not_required(view_func):
return view_func


__all__ = [
"login_not_required",
]
4 changes: 4 additions & 0 deletions src/pwa/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,10 @@
from django.shortcuts import render

from . import app_settings
from ._compat import login_not_required


@login_not_required
def service_worker(request): # noqa: ARG001
with open(app_settings.PWA_SERVICE_WORKER_PATH) as serviceworker_file:
return HttpResponse(
Expand All @@ -12,6 +14,7 @@ def service_worker(request): # noqa: ARG001
)


@login_not_required
def manifest(request):
return render(
request,
Expand All @@ -25,5 +28,6 @@ def manifest(request):
)


@login_not_required
def offline(request):
return render(request, "offline.html")
35 changes: 35 additions & 0 deletions tests/test_view.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
from http import HTTPStatus

import django
import pytest
from django.test import modify_settings
from django.urls import reverse
from pytest_django.asserts import assertContains, assertTemplateUsed

Expand All @@ -10,6 +13,18 @@ def test_service_worker_get(client):
assert response.status_code == HTTPStatus.OK


@pytest.mark.skipif(django.VERSION < (5, 1), reason="LoginRequiredMiddleware was introduced on Django 5.1")
def test_service_worker_get_unauthenticated(client):
with modify_settings(
MIDDLEWARE={
"append": "django.contrib.auth.middleware.LoginRequiredMiddleware",
}
):
response = client.get(reverse("pwa:serviceworker"))

assert response.status_code == HTTPStatus.OK


def test_manifest_get(client):
response = client.get(reverse("pwa:manifest"), format="json")

Expand Down Expand Up @@ -37,7 +52,27 @@ def test_manifest_get(client):
assertContains(response, expected)


@pytest.mark.skipif(django.VERSION < (5, 1), reason="LoginRequiredMiddleware was introduced on Django 5.1")
def test_manifest_get_unauthenticated(client):
response = client.get(reverse("pwa:manifest"), format="json")

assert response.status_code == HTTPStatus.OK
assert response["content-type"] == "application/json"


def test_offline_get(client):
response = client.get(reverse("pwa:offline"), format="json")

assert response.status_code == HTTPStatus.OK


@pytest.mark.skipif(django.VERSION < (5, 1), reason="LoginRequiredMiddleware was introduced on Django 5.1")
def test_offline_get_unauthenticated(client):
with modify_settings(
MIDDLEWARE={
"append": "django.contrib.auth.middleware.LoginRequiredMiddleware",
}
):
response = client.get(reverse("pwa:offline"), format="json")

assert response.status_code == HTTPStatus.OK