Conversation
|
At least one CI job has failed (in CI org) |
|
Note - closed previous PR because this required a non-standard CI file - should probably split to own card to add CI here |
b0b1d2d to
165be39
Compare
|
Module is ancient, used tabs not spaces so every line was changed by phpcbf. Also used phpunit 3. Was built for CMS 3, not idea if this still functions correctly in CMS 4, particularly DatabaseConnector.php which has There's a very non-standard thing bin/build-phar which created sspak.phar and the intention was to regularly rebuild the sspak.phar. This I don't think this actually functions as the integration in travis looks broken, even though the build there is green. I couldn't get SmokeTest.php to work as my local php.ini wouldn't let me create a phar when trying to run bin/build-phar I've done some work around getting the PSR4 loader working, adding phpcs, getting phpunit9 working, adding ci.yml. However it feels very messy and incomplete and I've done zero manual testing. I'm not attached to anything here so I'm happy to throw this PR out and start again and just copy some bits from this PR We'll need to spend some working out what we want to do here |
Issue https://github.com/silverstripeltd/product-issues/issues/570
CI for this PR is run on the creative-commoners org: https://github.com/creative-commoners/sspak/actions