feat: Add support for chromecast by judicaelandria · Pull Request #3 · silvermine/videojs-remoteplayback

judicaelandria · 2025-10-31T10:54:16Z

No description provided.

kmuncie

@judicaelandria here is a very surface level review to consider before @joshuacurtiss is back and able to give this a thorough review.

kmuncie · 2026-01-28T14:42:09Z

src/js/chromecast/ChromecastManager.ts

+    * (e.g. the Chromecast button) can respond to connect / connecting /
+    * disconnect transitions.
+    */
+   private _setupEventListeners(): void {


Do we need to cleanup these listeners at some point? Should we add a dispose() method that removes these listeners, similar to how ChromecastButton handles cleanup at ChromecastButton.ts:287-291, or is that handled somewhere else?

Looks like you aimed to solve this one, I will leave this open until @joshuacurtiss has a look

kmuncie · 2026-01-28T14:50:27Z

src/js/chromecast/ChromecastButton.ts

+   private _setupDirectAPIListeners(): void {
+      const videoElement = getVideoElement(this._player);
+
+      if (!videoElement || !checkClientChromecastSupport()) {


Would it be better to handle the !checkClientChromecastSupport down on L285 instead of here?

kmuncie · 2026-01-28T14:51:30Z

src/js/chromecast/ChromecastManager.ts

+      }
+
+      if (!this._isSetup) {
+         throw new Error('ChromecastManager not properly initialized. Call setup first.');


Issue: Error message says "Call setup first" but there's no public setup() method - initialization happens automatically in the constructor. Suggestion: Revise to: ChromecastManager initialization failed - video element with Remote Playback support not found.

kmuncie · 2026-01-28T14:54:42Z

src/styles/chromecast.scss

+
+/* Ensure button is visible when Chromecast is available */
+.vjs-chromecast-button:not(.vjs-hidden) {
+   display: block;


Is block correct here? I see alot of out rules for buttons above setting flex?

I see you removed this block entirely, was it actually not needed at all?

no, we didn't need it

kmuncie · 2026-01-28T14:56:20Z

src/js/constants/log-messages.ts

+   CHROMECAST_NOT_SUPPORTED: 'Chromecast not supported on this device',
+   CHROMECAST_SUPPORTED: 'Chromecast support detected',
+   GOOGLE_CAST_SUPPORTED: 'Google Cast API supported - full device compatibility',
+   GOOGLE_CAST_PREFERRED: 'Using Google Cast API for full device list',


These two GOOGLE_CAST... constants are apparently never used, is that intentional?

I see they were deleted.

kmuncie · 2026-01-28T14:57:37Z

src/styles/chromecast.scss

@@ -0,0 +1,49 @@
+$icon-chromecast--default: '../assets/ic_cast_white_24px.svg' !default;
+$icon-chromecast--hover: '../assets/ic_cast_connected_white_24dp.png' !default;


Whats up with the mixed file types? SVG for normal button and then hover switches to PNG? Do we need better assets for hover?

I dont see any changes here but I assume it will be considered further

fixed @kmuncie

- Implement core Chromecast functionality for the plugin

The AirPlay getVideoElement function returns an HTMLVideoElementWithAirPlay type, while Chromecast's getVideoElement returns a standard HTMLVideoElement. This type mismatch could cause runtime errors when the functions are used interchangeably.

judicaelandria marked this pull request as draft November 10, 2025 15:41

judicaelandria force-pushed the mandriamahandry/add-chromecast-support branch 4 times, most recently from dd83b05 to fe3ba58 Compare November 11, 2025 05:40

judicaelandria changed the title ~~feat: add chromecast support~~ feat: Implements Chromecast functionality for Video.js with remoteplayback API Nov 11, 2025

judicaelandria force-pushed the mandriamahandry/add-chromecast-support branch from fe3ba58 to f92a3dc Compare November 11, 2025 07:06

judicaelandria closed this Jan 20, 2026

judicaelandria reopened this Jan 20, 2026

judicaelandria force-pushed the mandriamahandry/add-chromecast-support branch 6 times, most recently from a91ed87 to 9bebbd8 Compare January 20, 2026 16:40

judicaelandria changed the title ~~feat: Implements Chromecast functionality for Video.js with remoteplayback API~~ feat: Add support for chromecast Jan 20, 2026

judicaelandria force-pushed the mandriamahandry/add-chromecast-support branch 6 times, most recently from fc8d9e3 to 7f2c9ca Compare January 27, 2026 07:27

judicaelandria marked this pull request as ready for review January 27, 2026 07:29

kmuncie reviewed Jan 28, 2026

View reviewed changes

judicaelandria force-pushed the mandriamahandry/add-chromecast-support branch from 7f2c9ca to 6b3def0 Compare January 30, 2026 13:41

judicaelandria added 3 commits February 2, 2026 18:33

feat: add support for Chromecast

c8e9b64

- Implement core Chromecast functionality for the plugin

refactor: change videojs test id to remoteplayback-test-player

5eaa61a

judicaelandria force-pushed the mandriamahandry/add-chromecast-support branch from 6b3def0 to e45da59 Compare February 2, 2026 15:33

judicaelandria requested a review from kmuncie February 2, 2026 15:33

		@@ -0,0 +1,49 @@
		$icon-chromecast--default: '../assets/ic_cast_white_24px.svg' !default;
		$icon-chromecast--hover: '../assets/ic_cast_connected_white_24dp.png' !default;

Comments

Conversation

judicaelandria commented Oct 31, 2025

Uh oh!

kmuncie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants