feat: implement StreamReader trait with FileStreamReader and HttpStreamReader#9
Merged
jjhafer merged 1 commit intosilvermine:masterfrom Dec 17, 2025
Merged
Conversation
polw1
force-pushed
the
stream_impl
branch
4 times, most recently
from
0fec372 to
56d2786
Compare
velocitysystems
suggested changes
Nov 28, 2025
velocitysystems
suggested changes
Dec 2, 2025
Contributor
|
Thanks @polw1. Once the remaining comments have been resolved please feel free to publish the PR. |
velocitysystems
approved these changes
Dec 17, 2025
Contributor
velocitysystems
left a comment
velocitysystems
left a comment
There was a problem hiding this comment.
Assigning to @jjhafer for final review and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add interface for reading media streams from local files and remote HTTP/HTTPS sources with direct offset access, enabling MP4 parsing that requires seeking to specific locations for box headers and payloads.