feat: implement metadata extraction for MP4 and MP3 formats#10
Open
polw1 wants to merge 1 commit intosilvermine:masterfrom
Open
feat: implement metadata extraction for MP4 and MP3 formats#10polw1 wants to merge 1 commit intosilvermine:masterfrom
polw1 wants to merge 1 commit intosilvermine:masterfrom
Conversation
polw1
force-pushed
the
metadata
branch
5 times, most recently
from
f1cf08f to
eb0a610
Compare
velocitysystems
suggested changes
Dec 25, 2025
Contributor
|
Thanks @polw1. When you're ready please push your changes and publish the PR. I will then re-review. |
velocitysystems
suggested changes
Jan 1, 2026
polw1
force-pushed
the
metadata
branch
2 times, most recently
from
c228821 to
8e322a8
Compare
velocitysystems
suggested changes
Jan 7, 2026
Contributor
velocitysystems
left a comment
velocitysystems
left a comment
There was a problem hiding this comment.
Thanks @polw1. Just re-reviewed and found two minor issues. Can you please resolve?
- Rename
getMetaValuetogetMetadataValue - Please remove unused "Hello.toml" permissions
velocitysystems
approved these changes
Jan 19, 2026
Contributor
|
Passing over to @jjhafer for final review. |
jjhafer
requested changes
Feb 13, 2026
Contributor
jjhafer
left a comment
jjhafer
left a comment
There was a problem hiding this comment.
@polw1 @velocitysystems I submitted a review by Claude. :smiling Back over to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add metadata extraction from local files and remote streams with partial reads via range requests,
Support for MP3 and MP4 metadata extraction.