Update main #3
Merged
Update main #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add model and data loading from minio * Add deepspeed config example * Validate starting of sync process, escape and quote path argument * Wait 1s before checking if sync process started * Fix for quotes in checkpointsRemote * Update readme and other edits for clarity * Update workloads/llm-finetune-llama-factory/helm/README.md Co-authored-by: Aku Rouhe <akurouhe@amd.com> --------- Co-authored-by: Aku Rouhe <akurouhe@amd.com>
* veRL GRPO finetuning ROCm example workload * Refactor and complete VeRL workload * Fix comments and typos --------- Co-authored-by: Emil Eirola <emil.eirola@amd.com>
* Add basic MLFlow export * Upgrade ROCm image. * Fix nested folders for artifacts on MLFlow EVEN BETTER! * Fix extra f-string --------- Co-authored-by: Sander Bijl de Vroe <Sander.BijldeVroe@amd.com>
…rmonise model names. Harmonise arg parser. (#354) * Fix erroneously removed LLM client URL prefix.
* Quote paths and escape chars in mc mirror * Fix handling of minio paths * Fix handling of quotes in echo statements
* Add on-boarding documentation for pre-commit * clarify cd in docs and fix <br /> * small edit
* WandB downloader * Make it work * Correct override name, always mount * No ephemeral storage, just emptyDir
sarooshsh
approved these changes
Jul 8, 2025
Brednas
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.