Try to prevent ai from commiting or pushing without permission

[myieye]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR implements project-level sync blocking functionality by adding guards to prevent synchronization when a project is blocked, introduces a new SyncBlocked job status, improves error handling for not-found scenarios, and reorganizes tests into serialized collections to prevent concurrency issues during FwHeadless sync operations.

Changes

Cohort / File(s)	Summary
Configuration & Issue Tracking .beads/config.yaml, .beads/issues.jsonl	Disabled no-db mode and updated issue entries with status transitions, timestamps, and dependency metadata; added new closed issues lb-14 and lb-15.
Documentation AGENTS.md	Enhanced workflow documentation with guidance on Git worktrees, protected branches, approval checkpoints, and compliance checks; no code changes.
Sync Blocking Logic backend/FwHeadless/Routes/MergeRoutes.cs, backend/FwHeadless/Services/SyncHostedService.cs	Injected ProjectMetadataService to add project sync-block checks with early-exit paths; added distributed tracing context; block merges when project is blocked.
Error Handling backend/LexBoxApi/Controllers/SyncController.cs, backend/LexBoxApi/Services/FwHeadlessClient.cs	Added NotFoundException handling in BlockProject/UnblockProject endpoints and client methods to return 404 on missing projects.
Sync Job Status backend/LexCore/Sync/SyncJobResult.cs	Added new SyncBlocked enum member to SyncJobStatusEnum.
Test Infrastructure backend/Testing/FwHeadless/FwHeadlessSyncCollection.cs, backend/Testing/ApiTests/DeleteProjectTests.cs, backend/Testing/FwHeadless/MergeFwDataWithHarmonyTests.cs, backend/Testing/ApiTests/ProjectBlockingTests.cs	Created serialized test collection FwHeadless Sync to disable parallel execution; added collection attribute to sync-related tests; introduced SyncedProjectFixture for shared test setup; refactored ProjectBlockingTests to use fixture instead of per-test project creation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Sync blocking logic integration: Verify that GetSyncBlockInfoAsync checks are correctly placed and that blocked projects return appropriate error states in both routes and workers.
• Error handling flow: Confirm NotFoundException is properly caught and distinguishes missing projects from other failures across controller and client layers.
• Test fixture refactoring: Review that SyncedProjectFixture properly initializes/tears down shared state and that EnsureProjectUnblocked() prevents test interference; validate collection serialization won't cause unexpected test ordering issues.

Possibly related PRs

• Make hard delete remove entire fw-headless project #2102: Adds project-level sync-blocking/status handling to the fw-headless sync flow with related job status changes.
• make project import resumable #1760: Modifies SyncHostedService.cs to add conditional early-exit behavior in the sync pipeline.
• Bug/1525 using code instead of name broke existing projects #1531: Updates SyncWorker constructor/API signature in SyncHostedService.cs.

Suggested labels

📦 Lexbox

Suggested reviewers

• rmunn
• jasonleenaylor

Poem

🐰 Hop-hop, the blocks now stand firm,
Sync gates guard each project's turn,
Tests in sync, no race to fear,
Fixtures share, the path is clear! ✨

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch add-kill-switch-for-fwlite-project

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a77a7c6 and 0330edc.

📒 Files selected for processing (12)

• .beads/config.yaml (1 hunks)
• .beads/issues.jsonl (1 hunks)
• AGENTS.md (5 hunks)
• backend/FwHeadless/Routes/MergeRoutes.cs (1 hunks)
• backend/FwHeadless/Services/SyncHostedService.cs (2 hunks)
• backend/LexBoxApi/Controllers/SyncController.cs (5 hunks)
• backend/LexBoxApi/Services/FwHeadlessClient.cs (2 hunks)
• backend/LexCore/Sync/SyncJobResult.cs (1 hunks)
• backend/Testing/ApiTests/DeleteProjectTests.cs (1 hunks)
• backend/Testing/ApiTests/ProjectBlockingTests.cs (7 hunks)
• backend/Testing/FwHeadless/FwHeadlessSyncCollection.cs (1 hunks)
• backend/Testing/FwHeadless/MergeFwDataWithHarmonyTests.cs (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}