Skip to content

Conversation

@hahn-kev
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Dec 10, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Updates to Malay and Swahili localization files with revised PO-Revision-Date timestamps and removal of one translation entry from the Malay catalog. Trailing newlines added to both files for formatting consistency.

Changes

Cohort / File(s) Summary
Localization file updates
frontend/viewer/src/locales/ms.po, frontend/viewer/src/locales/sw.po
Updated PO-Revision-Date from 2025-11-22 11:51 to 2025-12-10 14:15; removed "Create Entry" translation entry from ms.po; added trailing newlines to both files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Timestamp updates are routine maintenance
  • Translation entry removal is a simple deletion with no dependencies
  • Trailing newline changes are cosmetic formatting

Possibly related PRs

Suggested labels

💻 FW Lite

Suggested reviewers

  • imnasnainaec

Poem

🐰 Hop along, dear translations true,
Dates refreshed, and entries grew new,
Malay whispers fade away,
While Swahili words here stay!
Newlines neat, the files so spry!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'New Crowdin updates' accurately describes the pull request which updates translation files from Crowdin (MS and SW locale files with timestamp and content updates).
Description check ✅ Passed No pull request description was provided by the author. The check is lenient and passes as long as description relates to changeset; absence of description is acceptable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

UI unit Tests

  1 files   45 suites   19s ⏱️
111 tests 111 ✅ 0 💤 0 ❌
160 runs  160 ✅ 0 💤 0 ❌

Results for commit a97a971.

♻️ This comment has been updated with latest results.

@argos-ci
Copy link

argos-ci bot commented Dec 10, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Dec 19, 2025, 2:46 PM

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

C# Unit Tests

146 tests  ±0   146 ✅ ±0   22s ⏱️ +3s
 22 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a97a971. ± Comparison against base commit 0249380.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
Testing.FwHeadless.ProjectMetadataServiceTests ‑ BlockAndUnblock_ClearsPreviousBlockInfo
Testing.FwHeadless.ProjectMetadataServiceTests ‑ IsBlockedFromSyncAsync_WhenNoBlockSet_ReturnsFalse
Testing.FwHeadless.ProjectMetadataServiceTests ‑ GetSyncBlockInfoAsync_WhenNoBlockSet_ReturnsNull
Testing.FwHeadless.ProjectMetadataServiceTests ‑ UnblockFromSyncAsync_ClearsPreviousBlockInfo

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the added context description!

❓ Shouldn't this pr also add vi to the language lists in

  • frontend/viewer/lingui.config.ts
  • frontend/viewer/src/lib/i18n/LocalizationPicker.svelte

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related 📙 Platform.Bible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants