-
-
Notifications
You must be signed in to change notification settings - Fork 5
Prevent editors from requesting beta access #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughA new localization string is added for beta access permission messaging, and the wheresMyProject page is updated to disable the beta request button for non-manager users while displaying a restriction notice. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
UI unit Tests 1 files ± 0 3 suites - 42 0s ⏱️ -19s Results for commit 95b5a5b. ± Comparison against base commit 846d917. This pull request removes 111 and adds 10 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
C# Unit Tests130 tests 130 ✅ 19s ⏱️ Results for commit 95b5a5b. ♻️ This comment has been updated with latest results. |
|
@copilot remove "text-sm" from the new message |
00b161f to
eba698a
Compare
rmunn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to just hide the early-access page entirely from people who can't join it yet? Alternatively, I think that a different user_not_in_beta message should be presented to people who can't click the button, because telling them "Click the button below" and then further down saying "You can't click this button" feels a bit rude.
|
@rmunn I changed it to:
|

I've got a surprising number of beta requests from editors who don't need it and probably requested it more or less out of curiosity.
So, this disables the "Request beta access" button for them.
Now only site admins and users who manage at least 1 project can request access.
Potentially org admins should also be able to request beta access, but nah. There's been no need for that so far and open beta will come soon enough.
UPDATE: changed text and hid button for non-managers:
