Minilcm diff API #1181
Merged
Minilcm diff API #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was current/previous now before after
# Conflicts: # backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs # backend/FwLite/FwLiteProjectSync.Tests/UpdateDiffTests.cs # backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs # backend/FwLite/MiniLcm/Models/Entry.cs
# Conflicts: # .idea/.idea.LexBox/.idea/dataSources.xml # backend/FwLite/FwLiteProjectSync.Tests/Fixtures/SyncFixture.cs
…recreated with the same Id
hahn-kev
commented
Oct 30, 2024
backend/FwLite/FwDataMiniLcmBridge.Tests/MiniLcmTests/BasicApiTests.cs
Outdated
Show resolved
Hide resolved
hahn-kev
commented
Oct 30, 2024
hahn-kev
commented
Oct 30, 2024
hahn-kev
commented
Oct 30, 2024
…han using a HashSet of versions
hahn-kev
commented
Oct 30, 2024
myieye
reviewed
Oct 30, 2024
backend/FwLite/FwDataMiniLcmBridge/Api/UpdateProxy/UpdateSenseProxy.cs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
had a chat with Tim, and we realized this approach won't work using version numbers and such, otherwise since updates could come from before that version was made, we can't reliably get that version, if we didn't then we could overwrite someone elses changes. |
This was referenced Nov 5, 2024
Merged
# Conflicts: # backend/FwLite/FwDataMiniLcmBridge/Api/FwDataMiniLcmApi.cs # backend/FwLite/FwLiteProjectSync.Tests/Fixtures/SyncFixture.cs # backend/FwLite/FwLiteProjectSync.Tests/UpdateDiffTests.cs # backend/FwLite/FwLiteProjectSync/CrdtFwdataProjectSyncService.cs # backend/FwLite/FwLiteProjectSync/DryRunMiniLcmApi.cs # backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs # backend/FwLite/LcmCrdt/LcmCrdtKernel.cs # backend/FwLite/MiniLcm/IMiniLcmWriteApi.cs # backend/FwLite/MiniLcm/InMemoryApi.cs # backend/FwLite/MiniLcm/SyncHelpers/EntrySync.cs
…hen an entry is created, fix issue with ordering of adding complex forms to an entry
myieye
approved these changes
Nov 13, 2024
Collaborator
myieye
left a comment
myieye
left a comment
There was a problem hiding this comment.
This looks good to me.
The commit removing object versions was a bit sad to look at 😢
backend/FwLite/MiniLcm.Tests/AutoFakerHelpers/EntryFakerHelper.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1127