Skip to content

Conversation

@hahn-kev
Copy link
Contributor

@hahn-kev hahn-kev commented Nov 27, 2024

this does not include a new Chorus version, nor does this upgrade other packages.

It does enable tests to be run via dotnet test though I ran into some test failures there (I believe they are caused by the different test environment though). When running via Rider all the tests pass. When running msbuild test, there's no failure, but there is this warning

 warning : NUnit3 (FLEx-ChorusPluginTests LfMergeBridgeTests LibFLExBridge-ChorusPluginTests LiftBridge-ChorusPluginTests RepositoryUtilityTests SIL.LCModel.Utils.Tests TriboroughBridge-ChorusPluginTests) returned with exit code 15

This change is Reviewable

@hahn-kev
Copy link
Contributor Author

the appveyor build is failing, but I can't see where it's configured, there's no yaml file, where is that configured?

@jasonleenaylor
Copy link
Contributor

I removed the appveyor build and thought I had disabled it. I've deleted it in appveyor now.
However, the unit test results aren't actually being reported at the moment (an oversight) that's how @rmunn managed to sneak in 15 failures.
I'll fix that in a PR shortly.

@jasonleenaylor
Copy link
Contributor

Oh, and an interesting bit of trivia, the response code from NUnit3 on a successful run with failed tests is the number of tests that failed.

@jasonleenaylor jasonleenaylor enabled auto-merge (rebase) November 27, 2024 22:52
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 13 of 14 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @hahn-kev)

@jasonleenaylor jasonleenaylor merged commit 4d87b23 into develop Nov 27, 2024
4 checks passed
@jasonleenaylor jasonleenaylor deleted the update-net462 branch November 27, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants