Skip to content

fix build#71

Merged
gadfort merged 2 commits intomainfrom
fix-1
Jan 28, 2026
Merged

fix build#71
gadfort merged 2 commits intomainfrom
fix-1

Conversation

@gadfort
Copy link
Member

@gadfort gadfort commented Jan 28, 2026

Summary by CodeRabbit

  • New Features

    • Added pad-ring configuration control ports to support expanded hardware functionality options.
  • Chores

    • Updated Python package dependencies to latest compatible versions for improved stability and support.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

📝 Walkthrough

Walkthrough

Two discrete changes: addition of twelve pad-ring configuration control ports to the hardware top-level module (all wired to constant zero), and updates to three Python dependency versions in the requirements file (siliconcompiler, lambdapdk, and lambdalib).

Changes

Cohort / File(s) Summary
Hardware Pad-Ring Configuration
hw/asic_top.v
Added 12 new pad-ring control ports (no_schmitt, no_fast, no_ds; ea_schmitt, ea_fast, ea_ds; so_schmitt, so_fast, so_ds; we_schmitt, we_fast, we_ds) to the padring instantiation, each wired to constant 'b0
Python Dependency Updates
python-requirements.txt
Updated package versions: siliconcompiler (0.25.x → 0.36.x), lambdapdk (0.2.x → 0.2.8), lambdalib (0.8.x → 0.9.0)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • fix lambdalib #70: Modifies python-requirements.txt to update lambdalib dependency version similar to this PR's lambdalib update.

Poem

🐰 Ports and wires, steadfast and true,
Twelve new companions in constant 'b0 hue,
Dependencies shimmer with versions grown bright,
The padring rings out—all is configured right!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'fix build' is vague and generic, lacking specificity about which build issue is being addressed or what changes are made. Consider a more descriptive title that specifies the nature of the build fix, such as 'Add pad-ring configuration ports and update Python dependencies' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@python-requirements.txt`:
- Around line 4-6: Update the lambdapdk version constraint in the requirements
list: replace the non-existent constraint "lambdapdk >= 0.2.8" with "lambdapdk
>= 0.2.7" so the dependency can be resolved; leave the other entries
(siliconcompiler >= 0.36.0 and lambdalib >= 0.9.0) unchanged.

Comment on lines +4 to +6
siliconcompiler >= 0.36.0
lambdapdk >= 0.2.8
lambdalib >= 0.9.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check that specified versions exist and are not yanked on PyPI.

python - <<'PY'
import json, urllib.request

pkgs = {
    "siliconcompiler": "0.36.0",
    "lambdapdk": "0.2.8",
    "lambdalib": "0.9.0",
}

for pkg, ver in pkgs.items():
    url = f"https://pypi.org/pypi/{pkg}/json"
    data = json.load(urllib.request.urlopen(url))
    releases = data.get("releases", {})
    if ver not in releases:
        print(f"{pkg} {ver}: NOT FOUND")
        continue
    yanked = any(file.get("yanked") for file in releases[ver])
    print(f"{pkg} {ver}: found, yanked={yanked}")
PY

Repository: siliconcompiler/zerosoc

Length of output: 153


🌐 Web query:

siliconcompiler 0.36.0 PyPI release

💡 Result:

SiliconCompiler 0.36.0 was released on PyPI on January 6, 2026 (install: pip install siliconcompiler==0.36.0). It provides an sdist (siliconcompiler-0.36.0.tar.gz) and a universal wheel (siliconcompiler-0.36.0-py3-none-any.whl), and requires Python >= 3.9. [1]

Release notes highlight a major schema change to better handle timing constraints by splitting mode-specific info from scenarios, plus several minor execution/flowgraph/tooling fixes. [2]

Sources: [1] https://pypi.org/project/siliconcompiler/0.36.0/ | [2] https://docs.siliconcompiler.com/en/stable/reference_manual/appendix/changelog.html


🌐 Web query:

lambdapdk 0.2.8 PyPI release

💡 Result:

As of January 28, 2026, lambdapdk version 0.2.8 is not published on PyPI. The latest PyPI release is 0.2.7, released on Jan 13, 2026 (release history shows 0.2.7 down through 0.2.0, with no 0.2.8). [1]


🌐 Web query:

lambdalib 0.9.0 PyPI release

💡 Result:

lambdalib v0.9.0 is published on PyPI and was released on January 27, 2026. It provides both a source tarball (lambdalib-0.9.0.tar.gz) and a universal wheel (lambdalib-0.9.0-py3-none-any.whl) and requires Python ≥ 3.9. [1]


Fix lambdapdk version constraint—0.2.8 does not exist on PyPI.

lambdapdk >= 0.2.8 cannot be satisfied; the latest published version is 0.2.7 (released Jan 13, 2026). Update the requirement to lambdapdk >= 0.2.7. The other two versions are available: siliconcompiler 0.36.0 (Jan 6, 2026) and lambdalib 0.9.0 (Jan 27, 2026).

🤖 Prompt for AI Agents
In `@python-requirements.txt` around lines 4 - 6, Update the lambdapdk version
constraint in the requirements list: replace the non-existent constraint
"lambdapdk >= 0.2.8" with "lambdapdk >= 0.2.7" so the dependency can be
resolved; leave the other entries (siliconcompiler >= 0.36.0 and lambdalib >=
0.9.0) unchanged.

@gadfort gadfort merged commit c1b0fdc into main Jan 28, 2026
3 checks passed
@gadfort gadfort deleted the fix-1 branch January 28, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant