Conversation
leontiad
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+81
to
+130
| fn decapsulate( | ||
| dk: &Self::MlKemDecapsulationKey, | ||
| ct: &Self::MlKemCiphertext, | ||
| ) -> Result<SharedSecret, ()> { | ||
| let shared_key = dk.decapsulate(ct).map_err(|_| ())?; | ||
| Ok(Zeroizing::new(shared_key.as_slice().to_vec())) | ||
| } | ||
| } | ||
|
|
||
| impl MlKemGenerate for MlKem768 { | ||
| type MlKemDecapsulationKey = | ||
| ml_kem::kem::DecapsulationKey<ml_kem::MlKem768Params>; | ||
| type MlKemEncapsulationKey = | ||
| ml_kem::kem::EncapsulationKey<ml_kem::MlKem768Params>; | ||
| type MlKemCiphertext = ml_kem::Ciphertext<MlKem768>; | ||
| fn generate<R: CryptoRng>( | ||
| rng: &mut R, | ||
| ) -> (Self::MlKemDecapsulationKey, Self::MlKemEncapsulationKey) { | ||
| <MlKem768 as KemCore>::generate(rng) | ||
| } | ||
|
|
||
| fn decapsulate( | ||
| dk: &Self::MlKemDecapsulationKey, | ||
| ct: &Self::MlKemCiphertext, | ||
| ) -> Result<SharedSecret, ()> { | ||
| let shared_key = dk.decapsulate(ct).map_err(|_| ())?; | ||
| Ok(Zeroizing::new(shared_key.as_slice().to_vec())) | ||
| } | ||
| } | ||
|
|
||
| impl MlKemGenerate for MlKem1024 { | ||
| type MlKemDecapsulationKey = | ||
| ml_kem::kem::DecapsulationKey<ml_kem::MlKem1024Params>; | ||
| type MlKemEncapsulationKey = | ||
| ml_kem::kem::EncapsulationKey<ml_kem::MlKem1024Params>; | ||
| type MlKemCiphertext = ml_kem::Ciphertext<MlKem1024>; | ||
| fn generate<R: CryptoRng>( | ||
| rng: &mut R, | ||
| ) -> (Self::MlKemDecapsulationKey, Self::MlKemEncapsulationKey) { | ||
| <MlKem1024 as KemCore>::generate(rng) | ||
| } | ||
|
|
||
| fn decapsulate( | ||
| dk: &Self::MlKemDecapsulationKey, | ||
| ct: &Self::MlKemCiphertext, | ||
| ) -> Result<SharedSecret, ()> { | ||
| let shared_key = dk.decapsulate(ct).map_err(|_| ())?; | ||
| Ok(Zeroizing::new(shared_key.as_slice().to_vec())) | ||
| } | ||
| } |
There was a problem hiding this comment.
All three ML-KEM parameter set implementations (512, 768, 1024) have identical decapsulate logic. This code duplication creates a maintenance burden. Consider refactoring to use a shared helper function or macro to reduce duplication and ensure consistency across all parameter sets.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entire logic for integrating ML-KEM is under crates/sl-messages/src/proto/scheme
All the other crates have been light touched in order to be lint happy as we introduce cicd