feat: add checkpointing into the backfill so we can resume from the l…#2762
feat: add checkpointing into the backfill so we can resume from the l…#2762knrc wants to merge 1 commit intosigstore:mainfrom
Conversation
…ast completed, contiguous index Signed-off-by: Kevin Conner <kev.conner@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2762 +/- ##
===========================================
- Coverage 66.46% 26.03% -40.43%
===========================================
Files 92 191 +99
Lines 9258 20236 +10978
===========================================
- Hits 6153 5269 -884
- Misses 2359 14138 +11779
- Partials 746 829 +83
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@knrc Could we simply write a log index periodically to disk to simplify this? Backfilling is idempotent, so we don't need to be overly precise with the latest index. |
Yes, that's possible but I felt it would be better to keep the checkpoint within the same storage so they are managed together. The code is already taking advantage of the idempotency when tracking/updating the checkpoint, and does expect to replay on out of sequence updates or errors. |
|
Given the amount of code needed for this, I'd strongly prefer a much simpler solution, especially given the shift to Rekor v2. |
…ast completed, contiguous index
Closes #2279
Summary
This pull request adds support for checkpointing the progress of the backfill process, allowing the process to resume from the last known, contiguous index. This addresses the issue of the backfill reprocessing information from the beginning each time it runs.
Release Note
Added support for checkpointing progress during the backfill operation, rerunning the backfill will resume from the last known, contiguous index instead of starting at the beginning.
Documentation