Applied os.path.basename() to variable used in os.path.join that come…

[jcatera-splunk]

…s from an external source (like the regex matches from markdown files).

Ticket: VULN-53953

Description of issue and solution:

Semgrep is flagging a Path Traversal vulnerability (CWE-22).
This vulnerability is often called a "Tarball" or "Zip Slip" vulnerability because it uses the same exploit technique: using ../ in a filename to write files outside of the intended directory.

The PR corrects the handling of the image_filename and output_path. Specifically, in process_images and your do_... functions:
process_images: You take a filename directly from a regex match (image_filename = p.group(1)) and join it to a path: os.path.join(OUTPUT_IMAGE_PATH, monitor + "/" + image_filename).
do_smart_agent_monitor: You take an output_filename from a function and join it: os.path.join(OUTPUT_DOC_PATH, output_filename)

I've wrapped path references with os.path.join.

[jnino-splunk]

Here you go https://splunk.atlassian.net/browse/VULN-53953

I don't understand the VULN and the fix so some more details would be great!